Repository navigation
🔒 Prevent Zip Slip vulnerabilities in archive extraction - #382
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fix Zip Slip and directory traversal vulnerabilities in
⚠️ Risk: Without these checks, malicious archives could overwrite arbitrary files outside the destination directory via symlink traversal, potentially leading to arbitrary code execution.
unzip_archiveanduntar_archiveby implementing filesystem-level canonicalization checks for symlinks.🛡️ Solution: Manually process archive entries by incrementally building paths and verifying canonicalized paths start with the canonicalized destination directory, preventing both path traversal and symlink escapes.
PR created automatically by Jules for task 16418141315617105708 started by @Tcode-Motion